Skip to content

Add DataFrame.merge() term entry #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 28, 2025
Merged

Add DataFrame.merge() term entry #6800

merged 10 commits into from
May 28, 2025

Conversation

Enrique-Macias
Copy link
Contributor

Description

Added a new term entry for the DataFrame.merge() method in Pandas. The entry includes:

  • A clear description of the merge() method and its purpose
  • Detailed syntax section with all parameters explained
  • Example demonstrating basic merge operation with output

Location: content/pandas/concepts/dataframe/terms/merge/merge.md

Issue Solved

Closes #6779

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented May 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this May 17, 2025
@mamtawardhani mamtawardhani added new entry New entry or entries pandas Python:Pandas entries status: under review Issue or PR is currently being reviewed labels May 17, 2025
mamtawardhani
mamtawardhani requested changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Enrique-Macias thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few changes, could you please review and modify those at your earliest convenience? Thank you! 😃

@Enrique-Macias
Copy link
Contributor Author

Hi @mamtawardhani ,
Thank you for your feedback!
I’ve made the requested changes and pushed the updates to this branch.
Please let me know if there’s anything else I should address.
Thanks again for your review!

mamtawardhani
mamtawardhani approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the edits @Enrique-Macias 😄

The entry looks good for a second round of review! 🚀

@Sriparno08 Sriparno08 self-assigned this May 26, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 26, 2025
Sriparno08
Sriparno08 approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged, @Enrique-Macias!

@Sriparno08 Sriparno08 merged commit d9e688d into Codecademy:main May 28, 2025
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @Enrique-Macias
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pandas/dataframe/merge

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 removed the status: under review Issue or PR is currently being reviewed label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels
new entry New entry or entries pandas Python:Pandas entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Pandas - DataFrame: .merge()
4 participants
@Enrique-Macias @CLAassistant @mamtawardhani @Sriparno08